On Wed, May 21, 2014 at 01:16:30AM +0100, James Hogan wrote: > On Tuesday 20 May 2014 16:47:10 Andreas Herrmann wrote: > > From: David Daney <david.daney@xxxxxxxxxx> > > > > Signed-off-by: David Daney <david.daney@xxxxxxxxxx> > > Signed-off-by: Andreas Herrmann <andreas.herrmann@xxxxxxxxxxxxxxxxxx> > These look similar to the kvm_hypercall${n} functions in > arch/{x86,s390}/include/asm/kvm_para.h. Does it make sense to define > that API in kvm_para.h for MIPS instead of this one? Yes, the functions should be moved to a separate header. Andreas