On Fri, Apr 18, 2014 at 5:24 PM, Florian Fainelli <f.fainelli@xxxxxxxxx> wrote: > 2014-04-17 0:21 GMT-07:00 Brian Norris <computersforpeace@xxxxxxxxx>: >> These defconfigs contain the CONFIG_M25P80 symbol, which is now >> dependent on the MTD_SPI_NOR symbol. Add CONFIG_MTD_SPI_NOR to the >> relevant defconfigs. > > so CONFIG_M25P80 should select CONFIG_MTD_SPI_NOR, right? in that > case, I do not think this is needed at all, as it would be > automatically picked up during the build and if someone refreshes the > defconfigs, although it cannot hurt. Can you reply to the cover letter? 3 people have made the same comment, and I had a rebuttal that I'm not sure if anyone considered yet. (And it wouldn't be picked up by 'savedefconfig', since it saves a minimal .config; when one symbol 'select's another, the latter is not needed in the defconfig) Brian
