Re: [PATCH 5/9] MIPS: Add numa api support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/04/2014 01:11 AM, Huacai Chen wrote:
Enable sys_mbind()/sys_get_mempolicy()/sys_set_mempolicy() for O32, N32,
and N64 ABIs.

Signed-off-by: Huacai Chen <chenhc@xxxxxxxxxx>

NACK.

You need compat versions of the syscalls...

Also current migrate_pages and move_pages syscalls need to use the compat wrappers for 32-bit ABIs.

David Daney


---
  arch/mips/kernel/scall32-o32.S |    4 ++--
  arch/mips/kernel/scall64-64.S  |    4 ++--
  arch/mips/kernel/scall64-n32.S |    6 +++---
  arch/mips/kernel/scall64-o32.S |    6 +++---
  4 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/mips/kernel/scall32-o32.S b/arch/mips/kernel/scall32-o32.S
index fdc70b4..7f7e2fb 100644
--- a/arch/mips/kernel/scall32-o32.S
+++ b/arch/mips/kernel/scall32-o32.S
@@ -495,8 +495,8 @@ EXPORT(sys_call_table)
  	PTR	sys_tgkill
  	PTR	sys_utimes
  	PTR	sys_mbind
-	PTR	sys_ni_syscall			/* sys_get_mempolicy */
-	PTR	sys_ni_syscall			/* 4270 sys_set_mempolicy */
+	PTR	sys_get_mempolicy
+	PTR	sys_set_mempolicy		/* 4270 */
  	PTR	sys_mq_open
  	PTR	sys_mq_unlink
  	PTR	sys_mq_timedsend
diff --git a/arch/mips/kernel/scall64-64.S b/arch/mips/kernel/scall64-64.S
index dd99c328..a4baf06 100644
--- a/arch/mips/kernel/scall64-64.S
+++ b/arch/mips/kernel/scall64-64.S
@@ -347,8 +347,8 @@ EXPORT(sys_call_table)
  	PTR	sys_tgkill			/* 5225 */
  	PTR	sys_utimes
  	PTR	sys_mbind
-	PTR	sys_ni_syscall			/* sys_get_mempolicy */
-	PTR	sys_ni_syscall			/* sys_set_mempolicy */
+	PTR	sys_get_mempolicy
+	PTR	sys_set_mempolicy
  	PTR	sys_mq_open			/* 5230 */
  	PTR	sys_mq_unlink
  	PTR	sys_mq_timedsend
diff --git a/arch/mips/kernel/scall64-n32.S b/arch/mips/kernel/scall64-n32.S
index f68d2f4..92db19e 100644
--- a/arch/mips/kernel/scall64-n32.S
+++ b/arch/mips/kernel/scall64-n32.S
@@ -339,9 +339,9 @@ EXPORT(sysn32_call_table)
  	PTR	compat_sys_clock_nanosleep
  	PTR	sys_tgkill
  	PTR	compat_sys_utimes		/* 6230 */
-	PTR	sys_ni_syscall			/* sys_mbind */
-	PTR	sys_ni_syscall			/* sys_get_mempolicy */
-	PTR	sys_ni_syscall			/* sys_set_mempolicy */
+	PTR	sys_mbind
+	PTR	sys_get_mempolicy
+	PTR	sys_set_mempolicy

Here


  	PTR	compat_sys_mq_open
  	PTR	sys_mq_unlink			/* 6235 */
  	PTR	compat_sys_mq_timedsend
diff --git a/arch/mips/kernel/scall64-o32.S b/arch/mips/kernel/scall64-o32.S
index 70f6ace..0230429 100644
--- a/arch/mips/kernel/scall64-o32.S
+++ b/arch/mips/kernel/scall64-o32.S
@@ -473,9 +473,9 @@ EXPORT(sys32_call_table)
  	PTR	compat_sys_clock_nanosleep	/* 4265 */
  	PTR	sys_tgkill
  	PTR	compat_sys_utimes
-	PTR	sys_ni_syscall			/* sys_mbind */
-	PTR	sys_ni_syscall			/* sys_get_mempolicy */
-	PTR	sys_ni_syscall			/* 4270 sys_set_mempolicy */
+	PTR	sys_mbind
+	PTR	sys_get_mempolicy
+	PTR	sys_set_mempolicy		/* 4270 */

And Here.


  	PTR	compat_sys_mq_open
  	PTR	sys_mq_unlink
  	PTR	compat_sys_mq_timedsend




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux