RE: [PATCH v2 0/2] MIPS: ftrace: Fix icache flush issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Viller Hsiao [mailto:villerhsiao@xxxxxxxxx]
> Sent: 22 February 2014 07:47
> To: linux-mips@xxxxxxxxxxxxxx
> Cc: rostedt@xxxxxxxxxxx; fweisbec@xxxxxxxxx; mingo@xxxxxxxxxx; ralf@linux-
> mips.org; Qais Yousef; Viller Hsiao
> Subject: [PATCH v2 0/2] MIPS: ftrace: Fix icache flush issue
> 
> In 32-bit mode, the start address of flushing icache is wrong because of error
> address calculation. It causes system crash at boot when dynamic function trace is
> enabled. This issue existed since linux-3.8.
> 
> In the patch set, I fixed the flushing range and refined the macros used by it to
> pass compilation.
> 
> Patch 1 is tried to improve the usability of some macros such that we can make
> patch 2 cleaner. Patch 2 fixes this issue.
> 
> This patch set is based on commit 7d3f1a5 of mips-for-linux-next branch.
> 
> Viller Hsiao (2):
>   MIPS: ftrace: Tweak safe_load()/safe_store() macros
>   MIPS: ftrace: Fix icache flush range error
> 

Both patches look good to me. Thanks for the fixes.

Reviewed-by: Qais Yousef <qais.yousef@xxxxxxxxxx>

Qais

>  arch/mips/include/asm/ftrace.h | 20 ++++++++++----------
>  arch/mips/kernel/ftrace.c      |  5 ++---
>  2 files changed, 12 insertions(+), 13 deletions(-)
> 
> --
> 1.8.4.3




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux