I think Paul Bolle's patch is correct and my first patch is not enough. So it needn't to make a separate patch, just take Paul's patch and my second patch is enough. On Mon, Feb 10, 2014 at 3:45 AM, Aaro Koskinen <aaro.koskinen@xxxxxx> wrote: > Hi, > > On Sun, Feb 09, 2014 at 05:26:59PM +0100, Jonas Gorski wrote: >> On Sun, Feb 9, 2014 at 2:32 PM, Paul Bolle <pebolle@xxxxxxxxxx> wrote: >> > Commit 597ce1723e0f ("MIPS: Support for 64-bit FP with O32 binaries") >> > introduced references to two undefined Kconfig macros. CONFIG_MIPS32_R2 >> > should clearly be replaced with CONFIG_CPU_MIPS32_R2. And CONFIG_MIPS64 >> > should apparently be replaced with CONFIG_64BIT. >> >> While I agree about the CONFIG_MIPS64 => CONFIG_64BIT replacement, I >> wonder if CONFIG_MIPS32_R2 shouldn't rather be CONFIG_CPU_MIPSR2 >> (maybe even the existing CONFIG_CPU_MIPS32_R2 are wrong here). > > FYI, the 64BIT part is already fixed by > <http://patchwork.linux-mips.org/patch/6506/>. I guess these two changes > could be separate patches. > > A. >