Re: [PATCH] MIPS: fpu.h: fix build when CONFIG_BUG is not set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 05, 2014 at 10:05:44PM +0200, Aaro Koskinen wrote:
> __enable_fpu produces a build failure when CONFIG_BUG is not set:
> 
> In file included from arch/mips/kernel/cpu-probe.c:24:0:
> arch/mips/include/asm/fpu.h: In function '__enable_fpu':
> arch/mips/include/asm/fpu.h:77:1: error: control reaches end of non-void function [-Werror=return-type]
> 
> This is regression introduced in 3.14-rc1. Fix that.
> 
> Signed-off-by: Aaro Koskinen <aaro.koskinen@xxxxxx>
> ---
>  arch/mips/include/asm/fpu.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/mips/include/asm/fpu.h b/arch/mips/include/asm/fpu.h
> index cfe092fc720d..6b9749540edf 100644
> --- a/arch/mips/include/asm/fpu.h
> +++ b/arch/mips/include/asm/fpu.h
> @@ -74,6 +74,8 @@ static inline int __enable_fpu(enum fpu_mode mode)
>  	default:
>  		BUG();
>  	}
> +
> +	return SIGFPE;
>  }
>  
>  #define __disable_fpu()							\
> -- 
> 1.8.5.3
> 

Looks good to me, thanks for catching that.

Paul



[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux