Hi John, On 21/01/14 16:52, John Crispin wrote: >> Add a Processor ID for the P5600 core and a case in cpu_probe_mips() for >> it. The cputype is set to CPU_PROAPTIV for now as it is in the same >> range of cores as proAptiv and doesn't currently need to be >> distinguished from it in the kernel. > The "currently" in that sentence tells me that you expect there to be a > need to distinguish it in future ? More an "I don't know at this stage whether there'll be a need to distinguish them in future". Even glancing at perf counters they look the same (but I haven't checked every one). > If this is the case, then the code should be added now rather than > correcting the code later. > I immediately had to think of the 1074k vs 74k patch that is in > linux-mti-3.10 and was posted a few days ago. Okay, fair enough, It does no real harm to re-do with a different CPU id. Thanks James
