Ping. > -----Original Message----- > From: Vivek Goyal [mailto:vgoyal@xxxxxxxxxx] > Sent: 12 December 2013 14:42 > To: Qais Yousef; Andrew Morton > Cc: linux-kernel@xxxxxxxxxxxxxxx; Michael Holzheu; linux-mips@xxxxxxxxxxxxxx; > stable@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] crash_dump: fix compilation error (on MIPS at least) > > Generally akpm picks the kexec/kdump arch independent changes. > > Andrew, can you please consider this patch for inclusion. > > Thanks > Vivek > > On Wed, Dec 11, 2013 at 11:43:32AM +0000, Qais Yousef wrote: > > > -----Original Message----- > > > From: Vivek Goyal [mailto:vgoyal@xxxxxxxxxx] > > > Sent: 05 December 2013 13:59 > > > To: Qais Yousef > > > Cc: linux-kernel@xxxxxxxxxxxxxxx; Andrew Morton; Michael Holzheu; > > > linux- mips@xxxxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx > > > Subject: Re: [PATCH] crash_dump: fix compilation error (on MIPS at > > > least) > > > > > > On Wed, Dec 04, 2013 at 03:58:22PM +0000, Qais Yousef wrote: > > > > In file included from kernel/crash_dump.c:2:0: > > > > include/linux/crash_dump.h:22:27: error: unknown type name ‘pgprot_t’ > > > > > > > > when CONFIG_CRASH_DUMP=y > > > > > > > > The error was traced back to this commit: > > > > > > > > 9cb218131de1 vmcore: introduce remap_oldmem_pfn_range() > > > > > > > > include <asm/pgtable.h> to get the missing definition > > > > > > > > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > > > Cc: Michael Holzheu <holzheu@xxxxxxxxxxxxxxxxxx> > > > > Cc: Vivek Goyal <vgoyal@xxxxxxxxxx> > > > > Cc: <linux-mips@xxxxxxxxxxxxxx> > > > > Cc: <stable@xxxxxxxxxxxxxxx> # 3.12 > > > > Reviewed-by: James Hogan <james.hogan@xxxxxxxxxx> > > > > Signed-off-by: Qais Yousef <qais.yousef@xxxxxxxxxx> > > > > --- > > > > > > Looks good to me. > > > > > > Acked-by: Vivek Goyal <vgoyal@xxxxxxxxxx> > > > > > > Vivek > > > > Hi, > > > > I failed to see this picked up by anyone. I'm not sure which tree it > > should go to to be honest. Do I need to add more people to the Cc? Or > > am I just being impatient? :) > > > > Thanks, > > Qais > > > > > > > > > I haven't tried any other architecture except mips. > > > > If OK this should be considered for stable 3.12 (CCed). > > > > > > > > include/linux/crash_dump.h | 2 ++ > > > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > > > > > diff --git a/include/linux/crash_dump.h > > > > b/include/linux/crash_dump.h index fe68a5a..7032518 100644 > > > > --- a/include/linux/crash_dump.h > > > > +++ b/include/linux/crash_dump.h > > > > @@ -6,6 +6,8 @@ > > > > #include <linux/proc_fs.h> > > > > #include <linux/elf.h> > > > > > > > > +#include <asm/pgtable.h> /* for pgprot_t */ > > > > + > > > > #define ELFCORE_ADDR_MAX (-1ULL) > > > > #define ELFCORE_ADDR_ERR (-2ULL) > > > > > > > > -- > > > > 1.7.1 > > > >
