2014/1/2 Hauke Mehrtens <hauke@xxxxxxxxxx>: > From: Cody P Schafer <devel@xxxxxxxxxx> > > Add a few Belkin F7Dxxxx entries, with F7D4401 sourced from online > documentation and the "F7D7302" being observed. F7D3301, F7D3302, and > F7D4302 are reasonable guesses which are unlikely to cause > mis-detection. > > It also appears that at least the F7D3302, F7D3301, F7D7301, and F7D7302 > have a shared boardtype and boardrev, so use that as a fallback to a > "generic" F7Dxxxx board. Cody, Hauke: I'm starring at this patch for 10 minutes now and it's still unclear for me. You say 3301, 3302, 7301 and 7302 have the same board_* entries stating they can be treated with a generic ID entry. At the same time you define BELKIN_F7D3301 and BELKIN_F7D3302... so they are not identical after all? Finally what about 4302? I can see it's untested, but for some reason you assign it to the separated enum entry. Is this not going to share config with the generic ones? Sorry, but it looks really messy to me.
