On Sun, Dec 15, 2013 at 08:14:24PM +0800, Huacai Chen wrote: > This patchset is prepared for the next 3.14 release for Linux/MIPS. > Loongson-3 is a multi-core MIPS family CPU, it is MIPS64R2 compatible > and has the same IMP field (0x6300) as Loongson-2. These patches make > Linux kernel support Loongson-3 CPU and Loongson-3 based computers > (including Laptop, Mini-ITX, All-In-One PC, etc.) In general this patchset is suffering from coding style issue. I would suggest you to use the script checkpatch.pl, in the scripts/ directory of the linux sources. It currently gives 1 error and 61 warnings for all the patches. You should try to fix most of them if not all, there are only some rare cases where the warning should be ignored. I am not going to report all the mistakes in the individual patch, the tool is doing that a lot better than me. Just don't forget to run it before submitting patches. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@xxxxxxxxxxx http://www.aurel32.net
