Re: [PATCH 5/5] spi: add bcm63xx HSSPI driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 04, 2013 at 03:04:48PM +0100, Jonas Gorski wrote:
> On Wed, Dec 4, 2013 at 2:38 PM, Mark Brown <broonie@xxxxxxxxxx> wrote:

> > This ought to be disable_unprepare().  It would also be better to move
> > this to runtime PM (you can set auto_runtime_pm to have the core manage
> > the enable and disable for you) since that will save a bit of power.

> I already set auto_runtime_pm to true. I basically copied what's
> currently in spi-bcm63xx.c *coughs*. Is there anything else needed
> besides what you mentioned?

You'll need to call pm_runtime_enable() and so on to turn on runtime PM
in probe() and reverse that in remove() but otherwise no, just adding
the runtime callbacks should be fine.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux