On 11/19/2013 04:02 AM, Ralf Baechle wrote: > On Mon, Nov 18, 2013 at 09:04:36PM +0000, Jason Baron wrote: > >> The panic_timeout value can be set via the command line option 'panic=x', or via >> /proc/sys/kernel/panic, however that is not sufficient when the panic occurs >> before we are able to set up these values. Thus, add a CONFIG_PANIC_TIMEOUT >> so that we can set the desired value from the .config. >> >> The default panic_timeout value continues to be 0 - wait forever, except for >> powerpc and mips, which have been defaulted to 180 and 5 respectively. This >> is in keeping with the fact that these arches already set panic_timeout in >> their arch init code. However, I found three exceptions- two in mips and one in >> powerpc where the settings didn't match these default values. In those cases, I >> left the arch code so it continues to override, in case the user has not changed >> from the default. It would nice if these arches had one default value, or if we >> could determine the correct setting at compile-time. > > It's more complicated - MIPS was using the global default with five MIPS > platforms overriding the default. > > I propose to kill these overrides for sanity unless somebody comes up > with a good argument. Patch below. > And so have the mips default be 0? IE drop the arch/mips/Kconfig bits from the patch I posted? (Which could of course be configured to a non-zero value by the user, if desired.) Thanks, -Jason
