Re: [PATCH 3/6] MIPS: Add support for the proAptiv cores

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/11/2013 07:59 PM, David Daney wrote:

This patch is a big collection of small unrelated changes.

Can you break it up so that there is one patch per change?

o Add new identifiers
o Probe for them.
o Add new cpu-features.
o tlb.h change.
o All the places you add 'case CPU_PROAPTIV'


Hi David,

Ok thanks I will split this patch into smaller patches.

[...]
diff --git a/arch/mips/kernel/cpu-probe.c b/arch/mips/kernel/cpu-probe.c
index c814287..8168e29 100644
--- a/arch/mips/kernel/cpu-probe.c
+++ b/arch/mips/kernel/cpu-probe.c
@@ -286,6 +286,13 @@ static inline unsigned int decode_config4(struct
cpuinfo_mips *c)
          && cpu_has_tlb)
          c->tlbsize += (config4 & MIPS_CONF4_MMUSIZEEXT) * 0x40;

+    if (cpu_has_tlb) {
+        if (((config4 & MIPS_CONF4_IE) >> 29) == 2) {
+            c->options |= MIPS_CPU_TLBINV;
+            pr_info("TLBINV/F supported, config4=0x%0x\n", config4);

... The probing functions don't print messages, so don't add this
pr_info().

Ok will do

Thanks for the review

--
markos



[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux