Re: [PATCH mips-for-linux-next] MIPS: fix genex.S build for non MIPS32r2 class processors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25/10/2013 07:26 μμ, Florian Fainelli wrote:
Commit d712357d ("MIPS: Print correct PC in trace dump after NMI
exception") introduced assembly code which uses the "ehb" instruction,
which is only available in MIPS32r2 class processors and causes such
build errors on MIPS32r1 processors:

   AS      arch/mips/kernel/genex.o
arch/mips/kernel/genex.S: Assembler messages:
arch/mips/kernel/genex.S:386: Error: opcode not supported on this
processor: mips32 (mips32) `ehb'
make[2]: *** [arch/mips/kernel/genex.o] Error 1
make[1]: *** [arch/mips/kernel] Error 2
make[1]: *** Waiting for unfinished jobs....

Use _ehb which properly substitutes to a nop or a real ehb depending on
the processor we are building for.

Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
---

Yep that looks good to me. Thanks for fixing it

Reviewed-by: Markos Chandras <markos.chandras@xxxxxxxxxx>

--
markos



[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux