Re: [PATCH] MIPS: Print correct PC in trace dump after NMI exception

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





markos

On 10/08/13 13:38, Ralf Baechle wrote:
On Tue, Oct 08, 2013 at 01:31:28PM +0100, Markos Chandras wrote:

If you were afraid gas might use $1 expanding this macro instruction - no,
it won't.  A belt & suspenders approach might be to drop in a ".set noat";
it would make the assembler throw an error if should ever see the need to
use $1.

yeah i don't think the assembler would pick $1 in this case but we
could add ".set noat" just to be safe i suppose.

Thanks for the review. Could you fix these problems for me or should
i submit a new patch?

It's trivial enough so I'm going to do it.

The NMI handler btw. was already wrapped with .set push; .set noat; ...
.set pop.

   Ralf

yeah i just noticed. Thank you!



[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux