RE: [PATCH] MIPS: Print correct PC in trace dump after NMI exception

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Markos,

Markos Chandras wrote on 2013-10-08:
> From: Leonid Yegoshin <Leonid.Yegoshin@xxxxxxxxxx>
> 
> An NMI exception delivered from YAMON delivers the PC in ErrorPC
> instead of EPC. It's also necessary to clear the Status.BEV
> bit for the page fault exception handler to work properly.
> 
> Signed-off-by: Leonid Yegoshin <Leonid.Yegoshin@xxxxxxxxxx>
> Signed-off-by: Markos Chandras <markos.chandras@xxxxxxxxxx>
> ---


> @@ -1506,10 +1511,14 @@ int register_nmi_notifier(struct notifier_block
> *nb)
> 
>  void __noreturn nmi_exception_handler(struct pt_regs *regs)
>  {
> +	char str[100];
> +
>  	raw_notifier_call_chain(&nmi_chain, 0, regs);
>  	bust_spinlocks(1);
> -	printk("NMI taken!!!!\n");
> -	die("NMI", regs);
> +	snprintf(str, 100, "CPU%d NMI taken, CP0_EPC=%lx\n",
> +		 smp_processor_id(), regs->cp0_epc);
> +	regs->cp0_epc = read_c0_errorepc();

If this is a YAMON specific fix, why is it done in a common file?

> +	die(str, regs);
>  }
>  
>  #define VECTORSPACING 0x100	/* for EI/VI mode */

Best Regards,
Thomas




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux