* Mark Salter <msalter@xxxxxxxxxx> wrote: > Remove messy dependencies from PARPORT_PC by having it depend on one > Kconfig symbol (ARCH_MAY_HAVE_PC_PARPORT) and having architectures > which need it, select ARCH_MAY_HAVE_PC_PARPORT in arch/*/Kconfig. > New architectures are unlikely to need PARPORT_PC, so this avoids > having an ever growing list of architectures to exclude. Those > architectures which do select ARCH_MAY_HAVE_PC_PARPORT in this > patch are the ones which have an asm/parport.h (or use the generic > version). > > Signed-off-by: Mark Salter <msalter@xxxxxxxxxx> > CC: Richard Henderson <rth@xxxxxxxxxxx> > CC: linux-alpha@xxxxxxxxxxxxxxx > CC: Vineet Gupta <vgupta@xxxxxxxxxxxx> > CC: Russell King <linux@xxxxxxxxxxxxxxxx> > CC: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > CC: Tony Luck <tony.luck@xxxxxxxxx> > CC: Fenghua Yu <fenghua.yu@xxxxxxxxx> > CC: linux-ia64@xxxxxxxxxxxxxxx > CC: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > CC: linux-m68k@xxxxxxxxxxxxxxxxxxxx > CC: Michal Simek <monstr@xxxxxxxxx> > CC: microblaze-uclinux@xxxxxxxxxxxxxx > CC: Ralf Baechle <ralf@xxxxxxxxxxxxxx> > CC: linux-mips@xxxxxxxxxxxxxx > CC: "James E.J. Bottomley" <jejb@xxxxxxxxxxxxxxxx> > CC: Helge Deller <deller@xxxxxx> > CC: linux-parisc@xxxxxxxxxxxxxxx > CC: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> > CC: Paul Mackerras <paulus@xxxxxxxxx> > CC: linuxppc-dev@xxxxxxxxxxxxxxxx > CC: Paul Mundt <lethal@xxxxxxxxxxxx> > CC: linux-sh@xxxxxxxxxxxxxxx > CC: "David S. Miller" <davem@xxxxxxxxxxxxx> > CC: sparclinux@xxxxxxxxxxxxxxx > CC: Guan Xuetao <gxt@xxxxxxxxxxxxxxx> > CC: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > CC: Ingo Molnar <mingo@xxxxxxxxxx> > CC: "H. Peter Anvin" <hpa@xxxxxxxxx> > CC: x86@xxxxxxxxxx > --- > drivers/parport/Kconfig | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/parport/Kconfig b/drivers/parport/Kconfig > index 70694ce..a079b18 100644 > --- a/drivers/parport/Kconfig > +++ b/drivers/parport/Kconfig > @@ -31,13 +31,17 @@ menuconfig PARPORT > > If unsure, say Y. > > +config ARCH_MAY_HAVE_PC_PARPORT > + bool > + help > + Select this config option from the architecture Kconfig if > + the architecture may have PC parallel port hardware. > + > if PARPORT > > config PARPORT_PC > tristate "PC-style hardware" > - depends on (!SPARC64 || PCI) && !SPARC32 && !M32R && !FRV && !S390 && \ > - (!M68K || ISA) && !MN10300 && !AVR32 && !BLACKFIN && \ > - !XTENSA && !CRIS && !H8300 > + depends on ARCH_MAY_HAVE_PC_PARPORT > > ---help--- > You should say Y here if you have a PC-style parallel port. All Since it's not a permission to have a parallel port but a possibility, I suspect the whole series needs a: s/MAY_HAVE/MIGHT_HAVE s/may have/might have Otherwise: Acked-by: Ingo Molnar <mingo@xxxxxxxxxx> Thanks, Ingo
