On Mon, Oct 07, 2013 at 05:10:19PM +0100, Markos Chandras wrote: > On 10/07/13 17:08, Ralf Baechle wrote: > >On Mon, Sep 23, 2013 at 07:40:26PM +0530, Ashok Kumar wrote: > >>Date: Mon, 23 Sep 2013 19:40:26 +0530 > >>From: Ashok Kumar <ashoks@xxxxxxxxxxxx> > >>To: linux-mips@xxxxxxxxxxxxxx, gerg@xxxxxxxxxxx > >>cc: ralf@xxxxxxxxxxxxxx, Ashok Kumar <ashoks@xxxxxxxxxxxx> > >>Subject: [PATCH] MIPS: fix mapstart when using initrd > >>Content-Type: text/plain > >> > >>When initrd is present in the PFN right after the _end, bootmem > >>bitmap(mapstart) overwrites it. So check for initrd_end in > >>mapstart calculation. > >> > >>Signed-off-by: Ashok Kumar <ashoks@xxxxxxxxxxxx> > >>--- > >>This is seen after the commit > >>"mips: fix start of free memory when using initrd" > >>in git://git.linux-mips.org/pub/scm/ralf/upstream-sfr.git branch > >> > >>Tested the image on MIPS platform creating the above > >>said scenario and initrd was corrupted. > > > >And it gloriously breaks the build if CONFIG_BLK_DEV_INITRD is disabled. > >Now most configurations will fail with something like: > > > >[...] > > LD vmlinux > >arch/mips/built-in.o: In function `setup_arch': > >(.init.text+0xff8): undefined reference to `initrd_end' > >arch/mips/built-in.o: In function `setup_arch': > >(.init.text+0xffc): undefined reference to `initrd_end' > >make[2]: *** [vmlinux] Error 1 > >make[1]: *** [sub-make] Error 2 > >make: *** [all] Error 2 > >make: Leaving directory `/home/ralf/src/linux/obj/lasat-build' > > > > Ralf > > > Hi Ralf, > > I just sent a patch for that > > http://patchwork.linux-mips.org/patch/6028/ Yes, I noticed that. I folded that into Greg's original patch as well. And now back to the scheduled development program :) Btw, brownie points for an #ifdef-less fix ... Ralf
