On Thu, Sep 26, 2013 at 10:35:31AM +0100, Markos Chandras wrote:
> Checking for n<0 && n>9 makes no sense because it can never
> be true. Moreover, we can have up to 64 vectored interrupts
> so BUG_ON(n>9) was wrong anyway.
>
> Signed-off-by: Markos Chandras <markos.chandras@xxxxxxxxxx>
> Acked-by: Steven J. Hill <Steven.Hill@xxxxxxxxxx>
> ---
> This patch is for the upstream-sfr/mips-for-linux-next tree
What gem ;-)
I think the intent was
BUG_ON(n < 0 || n > 9);
and 9 probably is the highest currently used value?
In any case that could have broken PowerTV which does the following:
if (cpu_has_veic || cpu_has_vint) {
int nvec = cpu_has_veic ? 64 : 8;
for (i = 0; i < nvec; i++)
set_vi_handler(i, asic_irqdispatch);
}
Nobody from PowerTV complained. Time to sharpen the axe!
Ralf
