On 09/19/2013 08:38 PM, thomas@xxxxxxxx wrote:
> sizeof when applied to a pointer typed expression gives the size of the
> pointer.
> Found by coccinelle spatch "misc/noderef.cocci"
Thanks for spotting this.
Is this a new rule or has just nobody checked that part of the kernel?
The from field in the mail is broken.
> Signed-off-by: Thomas Meyer <thomas@xxxxxxxx>
Acked-by: Hauke Mehrtens <hauke@xxxxxxxxxx>
> diff -u -p a/arch/mips/bcm47xx/sprom.c b/arch/mips/bcm47xx/sprom.c
> --- a/arch/mips/bcm47xx/sprom.c
> +++ b/arch/mips/bcm47xx/sprom.c
> @@ -162,7 +162,7 @@ static void nvram_read_alpha2(const char
> pr_warn("alpha2 is too long %s\n", buf);
> return;
> }
> - memcpy(val, buf, sizeof(val));
> + memcpy(val, buf, sizeof(*val));
> }
>
> static void bcm47xx_fill_sprom_r1234589(struct ssb_sprom *sprom,
>
