On 09/12/2013 08:23 PM, Leonid Yegoshin wrote: > On 09/12/2013 12:28 AM, Lars-Peter Clausen wrote: >> On 09/11/2013 09:51 PM, Steven J. Hill wrote: >>> From: Leonid Yegoshin <Leonid.Yegoshin@xxxxxxxxxx> >>> >>> If CONFIG_CSRC_GIC is selected and the GIC is not found during >>> boot, then fallback to the R4K counter gracefully. >> Is there any reason not to always register the r4k clocksource, no matter >> whether the gic clocksource is present or not? The timekeeping core of the >> kernel will make sure to use the best available clocksource based on the >> clocksource's rating. >> >> - Lars > If you do power saving by switching some core OFF then you should do an > additional clock sync after core revival. > GIC is free from that but R4K is not. It was a primary reason for GIC > clocksource. Ok, but what I was saying is that there is no need to not register the r4k clocksource if the gic clocksource is present since the kernel can deal with multiple registered clocksources just fine. This is not a problem that needs to be solved in MIPS specific code, if the rating for the clocksources is set properly the kernel will switch to the gic clocksource as soon as it is registered and ignore the r4k clocksource. No need to do any reference to the gic in the r4k clocksource code. - Lars
