Re: [PATCH] MIPS: do not allow building vmlinuz when !ZBOOT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Florian,

On 28/08/13 16:42, Florian Fainelli wrote:
> +ifdef CONFIG_SYS_SUPPORTS_ZBOOT
>  # boot/compressed
>  vmlinuz vmlinuz.bin vmlinuz.ecoff vmlinuz.srec: $(vmlinux-32) FORCE
>  	$(Q)$(MAKE) $(build)=arch/mips/boot/compressed \
>  	   VMLINUX_LOAD_ADDRESS=$(load-y) 32bit-bfd=$(32bit-bfd) $@
> +else
> +vmlinuz:

Does this need a dependency on FORCE so that if you switched config and
had a valid vmlinuz lying around it doesn't do nothing as a result of
vmlinuz having no dependencies and existing?

> +	@echo '   CONFIG_SYS_SUPPORTS_ZBOOT is not enabled'

Also it may be worth adding false here too so that make's exit code
reports failure correctly.

Cheers
James



[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux