Re: [PATCH 2/2] MIPS: Remove unreachable break statements from cp1emu.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 19, 2013 at 12:10:35PM -0700, David Daney wrote:

> There were many cases of:
> 
>    return something;
>    break;
> 
> All those break statements are unreachable and thus redundant.

And are generally making code harder to read.

There seems to be a school of thought which believes that any case
block should end in a break - but those seem to not yet have heared
of Duff's Device or the syntatical candy in C that makes it possible.

Patch queued for 3.12.  Thanks,

  Ralf


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux