> The nlm_early_serial_setup code needs the early_serial_setup symbol > which is only available if CONFIG_SERIAL_8250 is selected. > Fixes the following build problem: > > arch/mips/built-in.o: In function `nlm_early_serial_setup': > setup.c:(.init.text+0x274): undefined reference to `early_serial_setup' > make: *** [vmlinux] Error 1 > > Signed-off-by: Markos Chandras <markos.chandras@xxxxxxxxxx> > --- > arch/mips/netlogic/xlr/setup.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/mips/netlogic/xlr/setup.c b/arch/mips/netlogic/xlr/setup.c > index 214d123..6d7d75e 100644 > --- a/arch/mips/netlogic/xlr/setup.c > +++ b/arch/mips/netlogic/xlr/setup.c > @@ -60,6 +60,7 @@ unsigned int nlm_threads_per_core = 1; > struct nlm_soc_info nlm_nodes[NLM_NR_NODES]; > cpumask_t nlm_cpumask = CPU_MASK_CPU0; > > +#ifdef CONFIG_SERIAL_8250 > static void __init nlm_early_serial_setup(void) > { > struct uart_port s; > @@ -78,6 +79,9 @@ static void __init nlm_early_serial_setup(void) > s.membase = (unsigned char __iomem *)uart_base; > early_serial_setup(&s); > } > +#else > +static inline void nlm_early_serial_setup(void) {} > +#endif > The UART device is on the SoC, so adding 'select SERIAL_8250' to the Kconfig for NLM_XLP_BOARD may be a better option. JC.