Re: [PATCH 1/2] DT: Add documentation for spi-rt2880

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 08/09/2013 10:51 PM, John Crispin wrote:

Describe the SPI master found on the MIPS based Ralink SoC.

Signed-off-by: John Crispin <blogic@xxxxxxxxxxx>
Cc: devicetree@xxxxxxxxxxxxxxx
Cc: linux-spi@xxxxxxxxxxxxxxx
Cc: linux-mips@xxxxxxxxxxxxxx
---
  .../devicetree/bindings/spi/spi-rt2880.txt         |   26 ++++++++++++++++++++
  1 file changed, 26 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/spi/spi-rt2880.txt

diff --git a/Documentation/devicetree/bindings/spi/spi-rt2880.txt b/Documentation/devicetree/bindings/spi/spi-rt2880.txt
new file mode 100644
index 0000000..d946626
--- /dev/null
+++ b/Documentation/devicetree/bindings/spi/spi-rt2880.txt
@@ -0,0 +1,26 @@
+Ralink SoC RT2880 and famile SPI master controller.
+
+Required properties:
+- compatible : "ralink,rt2880-spi"
+- reg : The register base for the controller.
+- #address-cells : <1>, as required by generic SPI binding.
+- #size-cells : <0>, also as required by generic SPI binding.
+
+Child nodes as per the generic SPI binding.
+
+Example:
+
+	spi@b00 {
+		compatible = "ralink,rt2880-spi";
+		reg = <0xb00 0x100>;
+
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		m25p80@0 {

Don't call nodes with chip names. ePAPR [1] says: "the name of a node should be somewhat generic, reflecting the function of the device and not its precise programming model". I suspect this is a flash device, ePAPR suggests using "flash" as a name in this case.

+			compatible = "m25p80";
+			reg = <0>;
+			spi-max-frequency = <10000000>;
+		};
+	};
+

WBR, Sergei



[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux