Re: [PATCH 1/2] MIPS: tlbex: Fix typo in r3000 tlb store handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 17, 2013 at 05:59:47PM +0800, Tony Wu wrote:
> Should test against handle_tlbs_end, not handle_tlbs.
> 
> Signed-off-by: Tony Wu <tung7970@xxxxxxxxx>
> Cc: Jayachandran C <jchandra@xxxxxxxxxxxx>
> ---
>  arch/mips/mm/tlbex.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/mm/tlbex.c b/arch/mips/mm/tlbex.c
> index 9ab0f90..605b6fc 100644
> --- a/arch/mips/mm/tlbex.c
> +++ b/arch/mips/mm/tlbex.c
> @@ -1803,7 +1803,7 @@ static void __cpuinit build_r3000_tlb_store_handler(void)
>  	uasm_i_j(&p, (unsigned long)tlb_do_page_fault_1 & 0x0fffffff);
>  	uasm_i_nop(&p);
>  
> -	if (p >= handle_tlbs)
> +	if (p >= handle_tlbs_end)
>  		panic("TLB store handler fastpath space exceeded");
>  
>  	uasm_resolve_relocs(relocs, labels);

Thanks for fixing this.

Acked-by: Jayachandran C. <jchandra@xxxxxxxxxxxx>

You should add the commit which caused the trouble to the commit message,
like:

commit 6ba045f (MIPS: Move generated code to .text for microMIPS) causes
a panic at boot.

JC.



[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux