On Mon, Jul 1, 2013 at 11:30 PM, Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx> wrote: > Dear Michael Ellerman, > > On Tue, 02 Jul 2013 10:53:16 +1000, Michael Ellerman wrote: >> On Mon, 2013-07-01 at 15:42 +0200, Thomas Petazzoni wrote: >> > Until now, the MSI architecture-specific functions could be overloaded >> > using a fairly complex set of #define and compile-time >> > conditionals. In order to prepare for the introduction of the msi_chip >> > infrastructure, it is desirable to switch all those functions to use >> > the 'weak' mechanism. This commit converts all the architectures that >> > were overidding those MSI functions to use the new strategy. >> >> The MSI code used to use weak functions, until we discovered they were >> being miscompiled on some toolchains (11df1f0). I assume these days >> we're confident they work correctly. > > Hum, interesting. I see from your commit that gcc 4.3.2 was apparently > affected, and gcc 4.3.x is not /that/ old. Bjorn, what's your point of > view on this? There *were* compilation issues with weak functions, but AFAIK they've been resolved and there's no reason to avoid them. Commit f9d142500 addressed this. Bjorn
