On Wednesday 26 June 2013 18:59, Ralf Baechle wrote: > On Wed, Jun 26, 2013 at 06:14:52PM +0200, Oleg Nesterov wrote: > > > Or simply remove the BUG_ON(), this can equally confuse wait(status). > > 128 & 0x7f == 0. > > > > Still I think it would be better to change _NSIG on mips. > > If it was that easy. That's going to outright break binary compatibility, > see kernel/signal.c: > > SYSCALL_DEFINE4(rt_sigprocmask, int, how, sigset_t __user *, nset, > sigset_t __user *, oset, size_t, sigsetsize) > { > sigset_t old_set, new_set; > int error; > > /* XXX: Don't preclude handling different sized sigset_t's. */ > if (sigsetsize != sizeof(sigset_t)) > return -EINVAL; > > There are several more more syscalls performing tests like the above. Reducing _NSIG to 127 (or 126) doesn't change sigset_t, so should be fine wrt above.