Re: [PATCH] MIPS: BMIPS: fix warnings for non BMIPS43xx builds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2013/6/27 Ralf Baechle <ralf@xxxxxxxxxxxxxx>:
> On Thu, Jun 27, 2013 at 11:45:15AM +0100, Florian Fainelli wrote:
>
>> Commit dccfb4c4 ("MIPS: BMIPS: support booting from physical CPU other
>> than 0") introduces the following warning when building for non
>> BMIPS43xx builds:
>>
>> arch/mips/kernel/smp-bmips.c:150:6: error: unused variable 'tpid'
>> [-Werror=unused-variable]
>>
>> Fix this by getting rid of this variable and directly using
>> cpu_logical_map(cpu).
>
> Sounds like the previous patch wasn't really tested - or somebody shot
> himself into the foot by removing the -Werror.

There is nothing in tree using BMIPS3300 or BMIPS5000 which are the
only two other possibilities where this warning could have been
caught.

>
> Anyway, folded in.

Thanks
--
Florian


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux