On 06/20/2013 03:29 PM, Jonas Gorski wrote:
When having enabled MIPS_PGD_C0_CONTEXT, trap_init() might call the
generated tlbmiss_handler_setup_pgd before it was committed to memory,
causing boot failures:
trap_init()
|- per_cpu_trap_init()
| |- TLBMISS_HANDLER_SETUP()
| |- tlbmiss_handler_setup_pgd()
|- flush_tlb_handlers()
To avoid this, move flush_tlb_handlers() into per_cpu_trap_init() to
ensure the generated handler is always committed on all cpus.
This issue was introduced in 3d8bfdd0307223de678962f1c1907a7cec549136
("MIPS: Use C0_KScratch (if present) to hold PGD pointer.").
Signed-off-by: Jonas Gorski <jogo@xxxxxxxxxxx>
---
V1 -> V2:
* Move flush_tlb_handlers into per_cpu_trap_init() to also fix it for
!boot_cpu.
Great work on finding this! This works on Malta with a 1074K in
uniprocessor and SMP kernel configurations. Linking a microMIPS kernel
is still broken as evidenced with:
mips-linux-gnu-ld: arch/mips/built-in.o: .cpuinit.text+0x1572:
Unsupported jump between ISA modes; consider recompiling with
interlinking enabled.
mips-linux-gnu-ld: final link failed: Bad value
make: *** [vmlinux] Error 1
The array:
u32 tlbmiss_handler_setup_pgd_array[16] __cacheline_aligned;
Needs to be replaced using the method in the commit "MIPS: Refactor
'clear_page' and 'copy_page' functions." with hash
c022630633624a75b3b58f43dd3c6cc896a56cff.
-Steve
