From: Florian Fainelli <florian@xxxxxxxxxxx> Date: Thu, 13 Jun 2013 09:58:34 +0100 > 2013/6/13 David Miller <davem@xxxxxxxxxxxxx>: >> From: Florian Fainelli <florian@xxxxxxxxxxx> >> Date: Wed, 12 Jun 2013 20:53:05 +0100 >> >>> +#ifdef BCMCPU_RUNTIME_DETECT >> >> I want the MIPS folks to fix this brain damange. >> >> This runtime detect thing is just a big mess in a header file >> using hundreds of lines of CPP stuff to express what is fundamentally >> a simple (albeit sizable) Kconfig dependency. > > The codebase supporting the Broadcom BCM63xx SoC supports about 6-7 You don't need to explain it to me, I read the code and understand what it's trying to accomplish. I reject the implementation of it, only. > No, the ifdefs are kept in the arch/mips/bcm63xx portions of the code > specifically for that reason. The driver just needs to take into account a > new set of platform_data properties to deal with this. Fine, it's still terrible.
