Re: [PATCH] MIPS: DEC: remove unbuildable promcon.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 30 May 2013, Paul Bolle wrote:

> promcon.o is built if CONFIG_PROM_CONSOLE is set. But there's no Kconfig
> symbol PROM_CONSOLE, so promcon.c is unbuildable. Remove it.
> 
> Signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx>
> ---
> 0) Untested.
> 
> 1) There used to be a Kconfig symbol PROM_CONSOLE. But it was SPARC
> specific and it was removed in v2.6.32, see commit 09d3f3f0e0 ("sparc:
> Kill PROM console driver.").
> 
> 2) Actually, it seems that it has never been possible to set
> PROM_CONSOLE for MIPS ever since this file was added in v2.3.9. I guess
> no-one noticed because (what seems to be) comparable functionality is
> provided in arch/mips/dec/prom/console.c.

 Yeah, I think over the years the file mostly served documentation 
purposes.  Given that we've had (as you also noticed) a working early-boot 
console available:

Acked-by: Maciej W. Rozycki <macro@xxxxxxxxxxxxxx>

 Thanks for this clean-up.

  Maciej


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux