On May 30, 2013, at 1:11 PM, Paolo Bonzini wrote: > Il 30/05/2013 20:35, Sanjay Lal ha scritto: >>>>>> +#endif >>>>>> + local_irq_save(flags); >>>>>> + if (kvm_mips_handle_vz_root_tlb_fault(badvaddr, vcpu) < 0) { >>>>>> + run->exit_reason = KVM_EXIT_INTERNAL_ERROR; >>>>>> + er = EMULATE_FAIL; >>>>>> + } >>>>>> + local_irq_restore(flags); >>>>>> + } >>>> >>>> This is introduced much later. Please make sure that, with >>>> CONFIG_KVM_MIPS_VZ, every patch builds. >>>> >>>> Paolo >>>> >> Again, I think this has to do with the fact that the patches were >> against 3.10-rc2, will rebase for v2. > > No, this is a simple patch ordering problem. > kvm_mips_handle_vz_root_tlb_fault is added in patch 11 only. > > Paolo > Ah I see what you mean. Will fix the ordering in v2. Thanks Sanjay