Re: [PATCH v3 1/3] MIPS: microMIPS: Fix POOL16C minor opcode enum

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 27 May 2013, Tony Wu wrote:

> diff --git a/arch/mips/include/uapi/asm/inst.h b/arch/mips/include/uapi/asm/inst.h
> index 0f4aec2..473a2ac 100644
> --- a/arch/mips/include/uapi/asm/inst.h
> +++ b/arch/mips/include/uapi/asm/inst.h
> @@ -409,10 +409,11 @@ enum mm_32f_73_minor_op {
>  enum mm_16c_minor_op {
>  	mm_lwm16_op = 0x04,
>  	mm_swm16_op = 0x05,
> -	mm_jr16_op = 0x18,
> -	mm_jrc_op = 0x1a,
> -	mm_jalr16_op = 0x1c,
> -	mm_jalrs16_op = 0x1e,
> +	mm_jr16_op = 0x0c,
> +	mm_jraddiusp_op = 0x18,
> +	mm_jrc_op = 0x0d,
> +	mm_jalr16_op = 0x1e,
> +	mm_jalrs16_op = 0x1f,
>  };

 Please keep these sorted by value, and also mm_jalr16_op and 
mm_jalrs16_op are wrong.

  Maciej


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux