On 05/23/2013 09:54 AM, Maciej W. Rozycki wrote:
On Thu, 23 May 2013, Maciej W. Rozycki wrote:
It looks to me do_bp would benefit from some polishing too.
To make myself more clear here -- there are two microMIPS BREAK encodings
of which do_bp assumes (without checking!) the 32-bit one, that is
actually unlikely to be ever present in compiler-generated code (so how
was this change validated?),
Probably sjhill should answer that, as they are his patches.
David Daney
and also the MIPS16 path is special-cased
(makes a separate call to do_trap_or_bp), which I find error-prone in
long-term maintenance.
Maciej
