Re: [PATCH] MIPS: N64: Define getdents64

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/21/2013 07:37 AM, Aron Xu wrote:
As a relatively new ABI, N64 only had getdents syscall while other modern
architectures have getdents64.

This was noticed when Python 3.3 shifted to the latter one for aarch64.

Signed-off-by: Aron Xu <aron@xxxxxxxxxx>

This looks correct to me. The getdents64 call returns more information than getdents (it adds a field for the file type). So, although in n64 the widths of the d_ino and d_off fields are the same for getdents64 and getdents, we still need to add this syscall.

Acked-by: David Daney <david.daney@xxxxxxxxxx>

---
  arch/mips/include/uapi/asm/unistd.h |    5 +++--
  arch/mips/kernel/scall64-64.S       |    1 +
  2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/mips/include/uapi/asm/unistd.h b/arch/mips/include/uapi/asm/unistd.h
index 16338b8..1dee279 100644
--- a/arch/mips/include/uapi/asm/unistd.h
+++ b/arch/mips/include/uapi/asm/unistd.h
@@ -694,16 +694,17 @@
  #define __NR_process_vm_writev		(__NR_Linux + 305)
  #define __NR_kcmp			(__NR_Linux + 306)
  #define __NR_finit_module		(__NR_Linux + 307)
+#define __NR_getdents64			(__NR_Linux + 308)

  /*
   * Offset of the last Linux 64-bit flavoured syscall
   */
-#define __NR_Linux_syscalls		307
+#define __NR_Linux_syscalls		308

  #endif /* _MIPS_SIM == _MIPS_SIM_ABI64 */

  #define __NR_64_Linux			5000
-#define __NR_64_Linux_syscalls		307
+#define __NR_64_Linux_syscalls		308

  #if _MIPS_SIM == _MIPS_SIM_NABI32

diff --git a/arch/mips/kernel/scall64-64.S b/arch/mips/kernel/scall64-64.S
index 36cfd40..97a5909 100644
--- a/arch/mips/kernel/scall64-64.S
+++ b/arch/mips/kernel/scall64-64.S
@@ -423,4 +423,5 @@ sys_call_table:
  	PTR	sys_process_vm_writev		/* 5305 */
  	PTR	sys_kcmp
  	PTR	sys_finit_module
+	PTR	sys_getdents64
  	.size	sys_call_table,.-sys_call_table




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux