On May 21, 2013, at 1:00 AM, Gleb Natapov wrote: > On Sun, May 19, 2013 at 10:36:32AM -0400, Sanjay Lal wrote: >> >> On May 19, 2013, at 8:52 AM, Gleb Natapov wrote: >> >>> On Sat, May 18, 2013 at 06:54:24AM -0700, Sanjay Lal wrote: >>>> - As suggested by Gleb, wrap calls to gfn_to_pfn() with srcu_read_lock/unlock(). >>>> Memory slots should be acccessed from a SRCU read section. >>>> - kvm_mips_map_page() now returns an error code to it's callers, instead of calling panic() >>>> if it cannot find a mapping for a particular gfn. >>>> >>>> Signed-off-by: Sanjay Lal <sanjayl@xxxxxxxxxxx> >>>> --- >>>> arch/mips/kvm/kvm_tlb.c | 36 +++++++++++++++++++++++++++--------- >>>> 1 file changed, 27 insertions(+), 9 deletions(-) >>>> >>>> diff --git a/arch/mips/kvm/kvm_tlb.c b/arch/mips/kvm/kvm_tlb.c >>>> index 89511a9..ab2e9b0 100644 >>>> --- a/arch/mips/kvm/kvm_tlb.c >>>> +++ b/arch/mips/kvm/kvm_tlb.c >>>> @@ -16,7 +16,10 @@ >>>> #include <linux/mm.h> >>>> #include <linux/delay.h> >>>> #include <linux/module.h> >>>> +#include <linux/bootmem.h> >>> You haven't answered it when I asked it on v2: >>> Is this include still needed now when export of min_low_pfn is not >>> longer here? >>> >> >> Sorry about that, juggling too many patches, bootmem.h is no longer needed in kvm_tlb.c. Actually, I thought I had removed it before posting v3. >> > Should I expect new version, or can I just drop this include from the > patch and apply? > Please drop the include. Regards Sanjay
