Re: [PATCH v2 1/2] usb: chipidea: big-endian support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/09/2013 11:22 PM, Svetoslav Neykov wrote:
> Hi Marc,
> 
> Marc Kleine-Budde [mailto:mkl@xxxxxxxxxxxxxx] (On Thursday, March 28, 2013
> 4:16 PM)
>> On 03/28/2013 10:28 AM, Alexander Shishkin wrote:
>>> Svetoslav Neykov <svetoslav@xxxxxxxxxxx> writes:
>>>
>>>> Convert between big-endian and little-endian format when accessing
>>>> the usb controller structures which are little-endian by
>>>> specification. Fix cases where the little-endian memory layout is
>>>> taken for granted. The patch doesn't have any effect on the already
>>>> supported little-endian architectures.
>>
>> Has anyone tested how the cpu_to_le32 and vice versa effects the
>> load/store operations? Does the compiler generate full 32 bit accesses
>> on mips (and big endian arm) or is a byte-shift-or pattern used?
> 
> Better late than never... I have checked your question, the value is loaded
> in a register and then swapped, so the read is performed only once.

Thanks for checking this.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux