Re: [PATCH 2/3] MIPS: BCM63XX: export PSI size from nvram

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le 12/05/2013 12:48, Jonas Gorski a écrit :
On Fri, May 10, 2013 at 2:36 PM, Artem Bityutskiy <dedekind1@xxxxxxxxx> wrote:
On Sat, 2013-03-23 at 14:07 +0100, Jonas Gorski wrote:
Signed-off-by: Jonas Gorski <jogo@xxxxxxxxxxx>
---
  arch/mips/bcm63xx/nvram.c                          |   11 +++++++++++
  arch/mips/include/asm/mach-bcm63xx/bcm63xx_nvram.h |    2 ++
  2 files changed, 13 insertions(+)

Acks from MIPS folks would be nice to have, but I pushed this patch to
the l2-mtd.git tree, thanks!

I had expected Florian's valid comment from preventing this series
from going in, but if you pushed it already then I will fix the return
type problem  that Florian pointed out in a separate patch (or rather
add add some range check for nvram.psi_size). Luckily it is a
theoretical issue only, as I haven't seen a device yet with an invalid
value.

Right, but this is no blocker from my perspective. As about the MIPS folks, Maxime, Kevin, Jonas and myself have been the "historical" contributors to the MIPS BCM63XX port, so I would consider Jonas to be authoritave here for these paches. John and Ralf usually do not comment unless the see something bad.
--
Florian


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux