On Thu, May 2, 2013 at 11:27 AM, EUNBONG SONG <eunb.song@xxxxxxxxxxx> wrote: > >>These are selects and don't prevent anyone else from also selecting >> them. If you look at your referenced commit, you see it removed the >>/depends/, not the selects. It actually added selects to several >> platforms. Platforms are supposed to select them if they need them. > > Hello. > Every time i config with arch/mips/configs/cavium_octeon_defconfig, the following warning messages > are showed. > warning: (MIPS_SEAD3 && PMC_MSP && CPU_CAVIUM_OCTEON) selects USB_EHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB && USB_EHCI_HCD) > warning: (MIPS_SEAD3 && PMC_MSP && CPU_CAVIUM_OCTEON) selects USB_EHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB && USB_EHCI_HCD) > > And after applying this patch, the warning messages were disappeared. But after this patch likely EHCI is also broken on these platforms. The solution is to either guard the USB_EHCI_BIG_ENDIAN_MMIO/DESC selects with if USB_EHCI_HCD etc, or make USB_EHCI_BIG_ENDIAN_MMIO/DESC not depend on USB_EHCI_HCD etc. As far as I can tell, USB_EHCI_BIG_ENDIAN_MMIO/DESC only have any effect on the ehci_hcd code anyway, so removing the dependencies of these symbols should be fine and without any side effects, thus allow platforms/drivers to select them unconditionally. Greg, what do you think? Jonas
