On Thu, Apr 18, 2013 at 3:24 PM, Andrew Murray <andrew.murray@xxxxxxx> wrote: > On Thu, Apr 18, 2013 at 02:44:01PM +0100, Grant Likely wrote: >> On Tue, 16 Apr 2013 11:18:27 +0100, Andrew Murray <Andrew.Murray@xxxxxxx> wrote: >> > /* Act based on address space type */ >> > res = NULL; >> > - switch ((pci_space >> 24) & 0x3) { >> > - case 1: /* PCI IO space */ >> > + res_type = range.flags & IORESOURCE_TYPE_BITS; >> > + if (res_type == IORESOURCE_IO) { >> >> Why the change from switch() to an if/else if sequence? > > Russell King suggested this change - see > https://patchwork.kernel.org/patch/2323941/ Umm, that isn't what that link shows. That link shows the patch already changing to an if/else if construct, and rmk is commenting on that. g.