On 16/04/13 06:05, Greg Kroah-Hartman wrote:
On Tue, Apr 16, 2013 at 05:55:38AM +0200, John Crispin wrote:On 15/04/13 20:14, Greg Kroah-Hartman wrote:On Sat, Apr 13, 2013 at 11:33:36AM +0200, John Crispin wrote:In order to make serial_8250 loadable via OF on Ralink WiSoC we need to default the iotype to UPIO_RT. Signed-off-by: John Crispin<blogic@xxxxxxxxxxx> --- drivers/tty/serial/of_serial.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c index b025d54..42f8550 100644 --- a/drivers/tty/serial/of_serial.c +++ b/drivers/tty/serial/of_serial.c @@ -98,7 +98,10 @@ static int of_platform_serial_setup(struct platform_device *ofdev, port->regshift = prop; port->irq = irq_of_parse_and_map(np, 0); - port->iotype = UPIO_MEM; + if (of_device_is_compatible(np, "ralink,rt2880-uart")) + port->iotype = UPIO_AU; + else + port->iotype = UPIO_MEM;Why are you putting device-specific things into a generic driver? Shouldn't this be able to be described in device tree without relying on an vendor-specific test in this driver? greg k-hHi Greg, would 'reg-io-type = "au";' sound better to you ?I don't know, run it by the device tree people, they know this stuff, I don't :( greg k-h
OK ... i don't know either, both proposals look crappy
John
