2013.02.15. 17:00 keltezéssel, John Crispin írta:
>
>>
>> - sprintf(ath79_sys_type, "Atheros AR%s rev %u", chip, rev);
>> + if (soc_is_qca955x())
>> + sprintf(ath79_sys_type, "Qualcomm Atheros QCA%s rev %u",
>> + chip, rev);
>> + else
>> + sprintf(ath79_sys_type, "Atheros AR%s rev %u", chip, rev);
>> pr_info("SoC: %s\n", ath79_sys_type);
>> }
>>
> Hi,
>
> maybe a soc_is_qca() could be used here, otherwise you will need to patch this
> line again for the next SoC and so on ....
Hm, if I would add a soc_is_qca() macro, I would have to patch that macro for
the next SoCs instead of this line.
Maybe it would be better to add the AR/QCA prefix to each chip name, and use
'Qualcomm Atheros' unconditionally in the sprintf call?
-Gabor
