2013/1/30 Rafał Miłecki <zajec5@xxxxxxxxx>: > I can see current code in cpu-probe.c handles some (very slightly) > different CPUs in the same way: > > case PRID_IMP_24K: > case PRID_IMP_24KE: > c->cputype = CPU_24K; > __cpu_name[cpu] = "MIPS 24Kc"; > break; > > There is almost nothing wrong about this, but setting the same name is > a little confusing for users. I wish to see different names in > /proc/cpuinfo for PRID_IMP_24K==24Kc and PRID_IMP_24KE==24KEc. > > Is there a preferred way of handling this? The simplest one seems to > be using separated "cases" while still using CPU_24K: > case PRID_IMP_24K: > c->cputype = CPU_24K; > __cpu_name[cpu] = "MIPS 24Kc"; > break; > case PRID_IMP_24KE: > c->cputype = CPU_24K; > __cpu_name[cpu] = "MIPS 24KEc"; > break; > > What do you think about this? Is this acceptable? > > For some reason I'm not aware of you may prefer adding CPU_24KE at the > same time. Does it make any sense? Yet another option would be to use __cpu_name[cpu] = "MIPS 24Kc / MIPS 24KEc"; User still won't know which CPU he has, but at least we won't make aware MIPS 24KEc owners confused. -- Rafał
