On Wed, Jan 16, 2013 at 02:24:26PM -0800, David Daney wrote: > ... In the very last BITFIELD_FIELD(), you need a valid token as the > second parameter, otherwise (according to Pinski) C90 behavior is > undefined. > > Use a ';' While Andrew is correct, I don't think this argument matters unless we're going to export <asm/inst.h> to userspace. Should we? Historically it was meant to be exported and accessed by application code from <sys/inst.h>. Ralf