On Tue, Jan 15, 2013 at 12:13:40AM -0600, Steven J. Hill wrote: > From: "Steven J. Hill" <sjhill@xxxxxxxx> > > This patch shows the use of macros in place of 'union mips_instruction' > type. I converted all usages of 'j_format' and 'r_format' to show how > the code and macros could look and be defined. I have tested these > changes on big and little endian platforms. > > I want input from everyone, please!!! I want consensus on the macro > definitions, placement of parenthesis for them, spacing in the header > file, etc. This is your chance to be completely anal and have fun > arguments over how things should be. I would also like input on how > the maintainers would like the patchsets to look like. For example: > > [1/X] - Convert 'j_format' > [2/X] - Convert 'r_format' > [3/X] - Convert 'f_format' > [4/X] - Convert 'u_format' > ... > [X/X] - Remove usage of 'union mips_instruction' type completely. > > Also, I noticed 'p_format' is not used anywhere. Can we kill it? Be > picky and help with this conversion. Thanks. Mayne not kill it completely abut leave a comment mentioning its existence for the sake of completeness. Ralf
