Re: [PATCH 7/8] ssb: add GPIO driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/20/2012 09:12 AM, John Crispin wrote:
> Hi Hauke,
> 
> 
>> +#ifdef CONFIG_SSB_DRIVER_EXTIF
> 
> ...
> 
>> +}
>> +
>> +#else
>> +static int ssb_gpio_extif_init(struct ssb_bus *bus)
>> +{
>> +    return 0;
>> +}
>> +#endif
> 
> ssb_gpio_extif_init() is also defined as a static inline stub in the
> header files. you should drop this definition from the code file
> 
>     John
No, ssb_gpio_extif_init() is only defined in drivers/ssb/driver_gpio.c
and not ssb_private.h, ssb_gpio_init() is defined in ssb_private.h.

Hauke


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux