On 11/14/2012 05:11 AM, Jonas Gorski wrote: > On 13 November 2012 06:02, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote: >> On 11/11/2012 05:50 AM, Jonas Gorski wrote: >>> Add definitions for the clocks found and used in all supported SoCs. >> >>> diff --git a/arch/mips/bcm63xx/dts/bcm6328.dtsi b/arch/mips/bcm63xx/dts/bcm6328.dtsi >> >>> + clocks { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + periph: pll { >>> + compatible = "brcm,bcm63xx-clock"; >>> + #clock-cells = <0>; >>> + clock-frequency = <50000000>; >>> + clock-output-names = "periph"; >>> + }; >> >> Here too, it seems like some reg properties would be required. > > This is more or less a dummy clock with no real backing for it, but > some of the drivers expect this clock to be present (even just to get > the frequency). Should compatible="fixed-clock" then if this is just a dummy? Ideally though, nothing "dummy" would be added to the DT; the kernel would continue to provide the dummy values via code until the DT was able to fully represent the actual HW.