Re: [PATCH] MIPS: Fix crash that occurs when function tracing is enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/15/2012 03:16 PM, Al Cooper wrote:
A recent patch changed some irq routines from inlines to functions.
These routines are called by the tracer code. Now that they're functions,
if they are compiled for function tracing they will call the tracer
and crash the system due to infinite recursion. The fix disables
tracing in these functions by using "notrace" in the function
definition.

Signed-off-by: Al Cooper <alcooperx@xxxxxxxxx>

Makes sense,

Reviewed-by: David Daney <david.daney@xxxxxxxxxx>


---
  arch/mips/lib/mips-atomic.c |    8 ++++----
  1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/mips/lib/mips-atomic.c b/arch/mips/lib/mips-atomic.c
index e091430..cd160be 100644
--- a/arch/mips/lib/mips-atomic.c
+++ b/arch/mips/lib/mips-atomic.c
@@ -56,7 +56,7 @@ __asm__(
  	"	.set	pop						\n"
  	"	.endm							\n");

-void arch_local_irq_disable(void)
+notrace void arch_local_irq_disable(void)
  {
.
.
.




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux