On 13 November 2012 06:04, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote: > On 11/11/2012 05:50 AM, Jonas Gorski wrote: >> Switch BCM63XX to the common clock framework and use clkdev for >> providing clock name lookups for non-DT devices. >> >> Clocks can have a frequency and gate-bit, or none, in case they >> are just provided for drivers expecting them to be present. > >> diff --git a/Documentation/devicetree/bindings/clock/bcm63xx-clock.txt b/Documentation/devicetree/bindings/clock/bcm63xx-clock.txt > > A very minor nit, but it might be nice to add the DT binding > documentation before (or as part of) the patches that use them (code > that parses them, or using the bindings in .dts files) > > Of course, I'm relying on my email receive order, to judge this since > the patch numbering didn't come through, so perhaps the patches are > already set up this way... No you are right, the bindings are being added earlier. I move it to the patch adding the (then still unused) binding to the dts(i) files. I'd rather not split it up completely, and add it with the binding usage together so it's easier to spot if I do something with the bindings that contradicts the documentation or is missing ;-). Jonas
